Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 24.7.0 #628

Merged
merged 8 commits into from
Jul 31, 2024
Merged

Release 24.7.0 #628

merged 8 commits into from
Jul 31, 2024

Conversation

adiroiban
Copy link
Member

@adiroiban adiroiban commented Jul 30, 2024 •
edited
Loading

Description

Fixes #616

Following the relase process at https://towncrier.readthedocs.io/en/latest/release.html

RC1 triggered here https://github.com/twisted/towncrier/actions/runs/10162467334

Drive by changes

  • Update the PR template to suggest linking to the associated issue
  • Update the pypi publishing as the old version was failing
  • Update the release docs with info about what to do if publishing fails

@adiroiban adiroiban requested a review from a team as a code owner July 30, 2024 12:03
@adiroiban
Copy link
Member Author

This is ready for review

@bentheiii @sigma67 @MetRonnie if you have time, please try the release candidate.

https://pypi.org/project/towncrier/24.7.0rc1/

I need at least one reviewer / tester to do the final release.

Thanks

MetRonnie
MetRonnie approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@MetRonnie MetRonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, all good from my point of view

@sigma67
Copy link
Contributor

sigma67 commented Jul 30, 2024

Tested, works for us

glyph
glyph approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@glyph glyph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and seems to work fine on https://blog.glyph.im

@hynek
Copy link
Member

hynek commented Jul 31, 2024

Tested and works for attrs.

@glyph
Copy link
Member

glyph commented Jul 31, 2024

I think I'm reasonably comfortable with accelerating the timeline on this one given the security content, and the multiple affirmations from different users.

@adiroiban
Copy link
Member Author

adiroiban commented Jul 31, 2024 •
edited
Loading

@glyph this is the PR for towncrier

For towncrier we don't have any fixed one week testing time.

As soon as one person reviews and tests the release, the release is good to go :)

I will trigger the final release, after the release I will update the branch and then merge it.

Many thanks for your reviews

Final release triggered here https://github.com/twisted/towncrier/actions/runs/10175759321

@adiroiban
Copy link
Member Author

Final release is now available on PyPi https://pypi.org/project/towncrier/24.7.0/

I have to go now, but I will fix the conflicts and will merge this soon.

Many thanks for all your help!

@adiroiban adiroiban merged commit 4ec2a29 into trunk Jul 31, 2024
16 checks passed
@adiroiban adiroiban deleted the release-24.7.0 branch July 31, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MetRonnie MetRonnie MetRonnie approved these changes

@sigma67 sigma67 sigma67 approved these changes

@glyph glyph glyph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release time?
5 participants
@adiroiban @sigma67 @hynek @glyph @MetRonnie